Skip to content

Conversation

@theskumar
Copy link
Member

@theskumar theskumar commented Aug 1, 2022

Related to #2882

The messaging.py has quite a lot of code with multiple concerns, which can be easily divided into individual independent modules.

This refractor puts different messaging adapters into it's own modules for better maintainability and readability

@theskumar theskumar requested a review from frjo August 1, 2022 12:15
@frjo frjo force-pushed the maintenance/theskumar/update-wagtail-3 branch from 2361652 to dc5c948 Compare August 1, 2022 12:36
Copy link
Member

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really liking these changes. Will make it easier and clearer to add new notification adapters.

Some tests are failing, will wait for the fix to them before deploying to test.

@theskumar
Copy link
Member Author

Will look into the test.

@theskumar theskumar force-pushed the refractor/messaging branch from e583c21 to c181119 Compare August 2, 2022 04:22
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #2938 (6be6bee) into maintenance/theskumar/update-wagtail-3 (dc5c948) will increase coverage by 0.02%.
The diff coverage is 87.85%.

@@                            Coverage Diff                             @@
##           maintenance/theskumar/update-wagtail-3    #2938      +/-   ##
==========================================================================
+ Coverage                                   81.93%   81.96%   +0.02%     
==========================================================================
  Files                                         697      704       +7     
  Lines                                       24914    24952      +38     
==========================================================================
+ Hits                                        20414    20452      +38     
  Misses                                       4500     4500              
Impacted Files Coverage Δ
hypha/apply/activity/adapters/emails.py 81.42% <81.42%> (ø)
hypha/apply/activity/adapters/activity_feed.py 83.50% <83.50%> (ø)
hypha/apply/activity/adapters/slack.py 88.35% <88.35%> (ø)
hypha/apply/activity/adapters/django_messages.py 94.44% <94.44%> (ø)
hypha/apply/activity/adapters/base.py 94.66% <94.66%> (ø)
hypha/apply/activity/adapters/__init__.py 100.00% <100.00%> (ø)
hypha/apply/activity/adapters/utils.py 100.00% <100.00%> (ø)
hypha/apply/activity/messaging.py 100.00% <100.00%> (+12.64%) ⬆️
hypha/apply/activity/tests/test_messaging.py 99.57% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc5c948...6be6bee. Read the comment docs.

@theskumar
Copy link
Member Author

@frjo The tests are passing now, this will merge to maintenance/theskumar/update-wagtail-3

@theskumar theskumar changed the base branch from maintenance/theskumar/update-wagtail-3 to main August 2, 2022 05:03
@theskumar theskumar changed the base branch from main to maintenance/theskumar/update-wagtail-3 August 2, 2022 05:03
@frjo frjo force-pushed the refractor/messaging branch from c181119 to 6be6bee Compare August 2, 2022 05:59
@frjo
Copy link
Member

frjo commented Aug 2, 2022

Deploying this to test now.

@frjo frjo temporarily deployed to test-hypha-app August 2, 2022 06:00 Inactive
@theskumar theskumar merged commit ddd00e3 into maintenance/theskumar/update-wagtail-3 Aug 11, 2022
@theskumar theskumar deleted the refractor/messaging branch August 16, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants