-
Notifications
You must be signed in to change notification settings - Fork 39
Refractor/messaging #2938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refractor/messaging #2938
Conversation
2361652 to
dc5c948
Compare
frjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really liking these changes. Will make it easier and clearer to add new notification adapters.
Some tests are failing, will wait for the fix to them before deploying to test.
|
Will look into the test. |
e583c21 to
c181119
Compare
Codecov Report
@@ Coverage Diff @@
## maintenance/theskumar/update-wagtail-3 #2938 +/- ##
==========================================================================
+ Coverage 81.93% 81.96% +0.02%
==========================================================================
Files 697 704 +7
Lines 24914 24952 +38
==========================================================================
+ Hits 20414 20452 +38
Misses 4500 4500
Continue to review full report at Codecov.
|
|
@frjo The tests are passing now, this will merge to |
c181119 to
6be6bee
Compare
|
Deploying this to test now. |
Related to #2882
The
messaging.pyhas quite a lot of code with multiple concerns, which can be easily divided into individual independent modules.This refractor puts different messaging adapters into it's own modules for better maintainability and readability