Replace urllib with requests #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon8787
approved these changes
Jun 21, 2024
| [project] | ||
| name = "uid2_client" | ||
| version = "2.4.6" | ||
| version = "3.0.0a1" |
Contributor
There was a problem hiding this comment.
is this how the version should be bumped, or is it done as part of the pipeline?
Contributor
There was a problem hiding this comment.
its done by the pipeline. It will bump up the major, minor or patch number corresponding to the Github action that's run. To publish an alpha package it will have to done manually
| token_generate_input.get_as_json_string().encode()) | ||
| resp = post(self._base_url, '/v2/token/generate', headers=auth_headers(self._auth_key), data=req) | ||
| resp_body = parse_v2_response(self._secret_key, resp.read(), nonce) | ||
| resp.raise_for_status() |
Contributor
There was a problem hiding this comment.
In future we should probably wrap base_url, auth_key, secret_key in their own class to get better reuse / single responsibility.
That class could have a method that replaces lines 50-54 with a single line (as those lines appear often):
resp_body = v2_request_helper.request('/v2/token/generate', token_generate_input.get_as_json_string())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping this in alpha for the moment. Two tests are failing, but they were failing before these changes.