UID2-3497: Add unit tests to test request of getting identity buckets #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnywu
reviewed
Jul 11, 2024
| @patch('uid2_client.identity_map_client.parse_v2_response') | ||
| def test_identity_buckets_request(self, mock_parse_v2_response, mock_post, mock_make_v2_request): | ||
| expected_timestamp = "2024-07-02T14:30:15.123456+00:00" | ||
| expected_req = json.dumps({"since_timestamp": get_datetime_utc_iso_format(dt.datetime.fromisoformat(expected_timestamp))}).encode() |
Contributor
There was a problem hiding this comment.
extra safety nit: could you add a second/separate expectation to compare with the hardcoded iso string output (instead of relating on the computed result from get_datetime_utc_iso_format) to ensure it is what we expect?
mcollins-ttd
approved these changes
Jul 11, 2024
|
|
||
| class IdentityMapUnitTests(unittest.TestCase): | ||
| identity_map_client = IdentityMapClient("UID2_BASE_URL", "UID2_API_KEY", "wJ0hP19QU4hmpB64Y3fV2dAed8t/mupw3sjN5jNRFzg=") | ||
| UID2_SECRET_KEY = "wJ0hP19QU4hmpB64Y3fV2dAed8t/mupw3sjN5jNRFzg=" |
Contributor
There was a problem hiding this comment.
Nitpick: Can we change this to
base64.b64encode(b"UID2_CLIENT_SECRET").decode()
so it's clear it isn't a real secret?
Contributor
Author
There was a problem hiding this comment.
That is a good idea. I changed it.
sunnywu
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.