Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/core-dump-handler/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ helm install core-dump-handler . --create-namespace --namespace observe \
<tr>
<td>AWS</td><td>EKS with IAM roles for service accounts</td><td><a href="values.aws.sts.yaml">values.aws.yaml</a></td>
</tr>
<tr>
<td>AWS</td><td>EKS with Bottlerocket nodes</td><td><a href="values.aws.bottlerocket.yaml">values.bottlerocket.yaml</a></td>
</tr>
<tr>
<td>AWS</td><td>ROSA</td><td><a href="values.openshift.yaml">values.openshift.yaml</a></td>
</tr>
Expand Down
9 changes: 9 additions & 0 deletions charts/core-dump-handler/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ spec:
- name: core-volume
mountPath: {{ .Values.daemonset.coreDirectory }}
mountPropagation: Bidirectional
{{- if .Values.daemonset.mountContainerRuntimeEndpoint }}
- mountPath: {{ .Values.daemonset.hostContainerRuntimeEndpoint }}
name: container-runtime
{{- end }}
env:
- name: COMP_FILENAME_TEMPLATE
value: {{ .Values.composer.filenameTemplate | quote }}
Expand Down Expand Up @@ -115,3 +119,8 @@ spec:
- name: core-volume
persistentVolumeClaim:
claimName: core-storage-pvc
{{- if .Values.daemonset.mountContainerRuntimeEndpoint }}
- name: container-runtime
hostPath:
path: {{ .Values.daemonset.hostContainerRuntimeEndpoint }}
{{- end }}
16 changes: 16 additions & 0 deletions charts/core-dump-handler/values.aws.bottlerocket.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# AWS requires a crio client to be copied to the server
daemonset:
includeCrioExe: true
deployCrioConfig: true
vendor: default
# Bottlerocket requires the host containerd socket mounted, it is located here as of 1.8.0
# Depending on the outcome of this issue, it may move in the future
# https://github.com/bottlerocket-os/bottlerocket/issues/2212
crioEndpoint: "unix:///run/dockershim.sock"
mountContainerRuntimeEndpoint: true
hostContainerRuntimeEndpoint: "/run/dockershim.sock"

serviceAccount:
annotations:
# See https://docs.aws.amazon.com/eks/latest/userguide/specify-service-account-role.html
eks.amazonaws.com/role-arn: arn:aws:iam::123456789000:role/iam-role-name-here
20 changes: 19 additions & 1 deletion charts/core-dump-handler/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,19 @@
"s3Secret"
]
}
}
},
{
"if": {
"properties": {
"mountContainerRuntimeEndpoint": {
"const": true
}
},
"required": [
"hostContainerRuntimeEndpoint"
]
}
}
],
"properties": {
"name": {
Expand Down Expand Up @@ -208,6 +220,12 @@
"crioEndpoint": {
"type": "string"
},
"mountContainerRuntimeEndpoint": {
"type": "boolean"
},
"hostContainerRuntimeEndpoint": {
"type": "string"
},
"includeCrioExe": {
"type": "boolean"
},
Expand Down
2 changes: 2 additions & 0 deletions charts/core-dump-handler/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ daemonset:
hostDirectory: "/var/mnt/core-dump-handler"
coreDirectory: "/var/mnt/core-dump-handler/cores"
crioEndpoint: "unix:///run/containerd/containerd.sock"
mountContainerRuntimeEndpoint: false
hostContainerRuntimeEndpoint: "/run/containerd/containerd.sock"
suidDumpable: 2
vendor: default
# interval: 60000
Expand Down