Merged
Conversation
Signed-off-by: Tim Buchwaldt <tim@buchwaldt.ws>
timbuchwaldt
changed the title
Collaborator
Author
|
@No9 ready for your input :) |
This adds a test, sets the default timeout to 120s and fixes the implementation to actually exit the process. Signed-off-by: Tim Buchwaldt <tim@buchwaldt.ws>
Collaborator
|
Travelling today but from what I can see on the mobile that looks cleaner than I was expecting. |
Collaborator
Author
|
Sure, no hurry, safe travels! |
No9
approved these changes
Oct 5, 2022
Collaborator
No9
left a comment
No9
left a comment
There was a problem hiding this comment.
Clean implementation and the integration tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #110.