Conversation
- Helm chart now supports injecting sidecar containers, adding envFrom instructions to read either configMaps as well as secrets. - Add sample sidecar to minikube values that prints the event file to stdout Signed-off-by: Raul Gonzales <gonzalesraul03@gmail.com>
No9
requested changes
Feb 3, 2023
Collaborator
No9
left a comment
No9
left a comment
There was a problem hiding this comment.
Thanks for this PR it's great to get support for more platforms
Would you mind updating the chart README values section so folks will know what's going on
https://github.com/IBM/core-dump-handler/blob/main/charts/core-dump-handler/README.md#values
Signed-off-by: Raul Gonzales <gonzalesraul03@gmail.com>
Contributor
Author
|
Done @No9, updated the README with the description of new values |
No9
approved these changes
Feb 6, 2023
Collaborator
|
@gonzalesraul Will release over the next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helm chart now supports injecting sidecar containers, adding envvars with
envFrominstructions to read either configMaps as well as secrets.Add sample sidecar to minikube values that prints the event file to stdout