Conversation
binarysta
force-pushed
the
pod_annotations
branch
from
9077327 to
5ee64f9
Compare
No9
reviewed
Aug 8, 2024
Collaborator
No9
left a comment
No9
left a comment
There was a problem hiding this comment.
Thanks for this
Can you update the daemonset notes in the readme
https://github.com/IBM/core-dump-handler/blob/main/charts/core-dump-handler/README.md and rebase onto main and I will merge and do a release.
binarysta
force-pushed
the
pod_annotations
branch
from
5ee64f9 to
28207d3
Compare
Contributor
Author
|
Thanks for reviewing. I updated the PR. |
No9
approved these changes
Aug 9, 2024
Collaborator
|
Approved but can you resign the commit to pass the DCO test please |
Signed-off-by: Ali Ghanbarzadeh <ghanbarzade.ali@gmail.com>
binarysta
force-pushed
the
pod_annotations
branch
from
28207d3 to
a4ba334
Compare
Contributor
Author
|
thanks. signed off. |
Collaborator
|
Thanks again for coming back so soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to address #161