Conversation
When `DEPLOY_CRIO_CONFIG` is `true`, both `image-endpoint` and `runtime-endpoint` are generated as hard coded values [here](https://github.com/IBM/core-dump-handler/blob/a67034ad7e807df956947b74b770a978235bf27b/core-dump-agent/src/main.rs#L422). This PR is to make them optionally configurable. To configure it, `daemonset.crioEndpoint` can now be set in `values.yaml`, which translates to the `CRIO_ENDPOINT` environment variable in the daemonset. Found this useful on setups that have dockershim. The default is still set to `unix:///run/containerd/containerd.sock`, so this should be backwards compatible.
Collaborator
|
Really appreciate the contribution. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
DEPLOY_CRIO_CONFIGistrue, bothimage-endpointandruntime-endpointare generated as hard coded values here. This PR is to make them optionally configurable. To configure it,daemonset.crioEndpointcan now be set invalues.yaml, which translates to theCRIO_ENDPOINTenvironment variable in the daemonset.Found this useful on setups that have dockershim. The default is still set to
unix:///run/containerd/containerd.sock, so this should be backwards compatible.