Skip to content

Conversation

@spanishpear
Copy link
Contributor

@spanishpear spanishpear commented Oct 16, 2025

Hi! I noticed that node-pre-gyp was out of date and quite large - this PR updates it :)
Thank you for all of your work! 💟


Fixes #436

node-pre-gyp had a major bump released 9 months ago to reflect their new >= Node18 support.
AFAIK this is not a breaking change for node-odbc given it has a minimum support of Node 18 as well.

They went from 58 deps to 19 - ~67% reduction.

Before (including node-odbc for context)

image

After

image

node-pre-gyp changelog for V2

https://github.com/mapbox/node-pre-gyp/releases/tag/v2.0.0 ⬇️
image

Signed-off-by: Shrey Somaiya <ssomaiya@atlassian.com>
@spanishpear spanishpear marked this pull request as ready for review October 16, 2025 12:07
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you please remove the package-lock.json changes? It looks like you have configured npm to use some Atlassian registries instead of npm which has affected this, plus I'd prefer to lock the deps myself.

@spanishpear
Copy link
Contributor Author

@kadler 🤦‍♀️ So sorry about that - default behaviour of npm i when I had my internal registry setup! Will fix

Signed-off-by: Shrey Somaiya <ssomaiya@atlassian.com>
@spanishpear
Copy link
Contributor Author

I've removed all of the package-lock.json changes - this means that package.json is out of sync, but I assume

plus I'd prefer to lock the deps myself.

infers that is desired here! Please let me know if that was incorrect, and I'll perform the package-lock.json update as normal

@kadler kadler merged commit 995c464 into IBM:main Oct 17, 2025
1 check passed
@spanishpear
Copy link
Contributor Author

spanishpear commented Nov 12, 2025

Heya @kadler 👋 thanks for merging these in 💜

Any chance we could get a 2.50 npm release with these changes?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecated dependencies in latest version v2.4.9.

2 participants