refactor: Remove ixml refs in CommandCall

[abmusse]

Part of #96

[abmusse]

Test CommandCallUnit.js:

  Command Call Unit Tests
    SH command tests
      ✓ accepts command input and returns <sh> XML output
      ✓ accepts command input and options returns <sh> with optional attributes
    CL command tests
      ✓ accepts command input and returns <cmd> XML output
      ✓ accepts command input and options returns <cmd> with optional attributes
    QSH command tests
      ✓ accepts command input and returns <qsh> XML output
      ✓ accepts command input and options returns <qsh> with optional attributes


  6 passing (8ms)

[kadler]

Similar to the other review, I would like to see these a little more DRY.

[abmusse]

I've updated the PR

[kadler]

Suggested change

	this.xml = `<${this.type} exec='${this.options.exec || defaultExec}'`;
	this.xml = `<cmd exec='${this.options.exec || defaultExec}'`;

No reason to change this.type. That would actually cause problems if they re-use it, since it will go through the else code path and not check for rexx execution.

[abmusse]

https://github.com/IBM/nodejs-itoolkit/pull/103/files#r381568163

[abmusse]

We would also need to up this.type here as well

[kadler]

Oh, right. I forgot we needed the type for the closing tag. I would suggest setting the local variable above then:

const type = this.type === 'cl' ? 'cmd' : this.type;
if(type == 'cmd') {
...
}
else {
...
}

[kadler]

Could even do:

const type = this.type === 'cl' ? 'cmd' : this.type;
this.xml = `<${this.type}`;

if (type == 'cmd') {
     const defaultExec = (this.command.indexOf('?') > 0) ? 'rexx' : 'cmd';
     this.xml += ` exec='${this.options.exec || defaultExec}'`;
}

[markirish]

LGTM

This looks so, so, so much cleaner and better. Especially love the availableCommands.join

[kadler]

LGTM