refactor: Remove ixml refs in ProgramCall#104
refactor: Remove ixml refs in ProgramCall#104abmusse merged 1 commit intoIBM:masterfrom abmusse:remove-ixml-for-programcall
Conversation
|
ProgramCall Class Unit Tests 8 passing (11ms) |
|
Looks like ProgramCall.addParam Could be simplified by creating another function that handles adding data structure parameters. That way we could avoid the recursive calls to addParam. This is out the scope of this PR therefore I will open a separate issue to track this. |
kadler
left a comment
There was a problem hiding this comment.
This looks good to me, other than addParam, which needs to be overhauled, but we'll do that in a separate PR. @markdirish can you double check I didn't miss anything?
markirish
left a comment
There was a problem hiding this comment.
It looks good to me.
I understand why we want to remove iXml, its a behemoth of a class and has a bunch of constants that can be extracted much more gracefully. I do think there is some value in having the XML templates in some sort of single location (even if thats a "single location" for each class, so a ProgramCall only needs and knows about the the templates that is uses) ... I guess you could argue that the functions ARE themselves ARE that single location. This definitely looks like a step in the right direction
Part of #96