test: Pass object to addParam in ProgramCallFunctional.js#195
Merged
kadler merged 1 commit intoIBM:masterfrom Mar 26, 2020
abmusse:update-programcall-tests
Merged
test: Pass object to addParam in ProgramCallFunctional.js#195kadler merged 1 commit intoIBM:masterfrom abmusse:update-programcall-tests
kadler merged 1 commit intoIBM:masterfrom
abmusse:update-programcall-tests
Conversation
Member
Author
|
abmusse
commented
Mar 26, 2020
| const paramValue = 'errno'; | ||
|
|
||
| program.addParam(errno, { io: 'both', len: 'rec2', name: paramValue }); | ||
| const outBuf = { |
Member
Author
There was a problem hiding this comment.
The second test in ProgramCallFunctional.js Does not seem useful.
Its the exact same test as the first the only difference it adds name field for errno DS.
We should remove it and add other useful ProgramCall functional tests.
Member
There was a problem hiding this comment.
yeah, I think the reason the name was originally in a variable was to test that it comes back, but it never did. Probably makes sense to just remove.
kadler
approved these changes
Mar 26, 2020
Member
kadler
left a comment
There was a problem hiding this comment.
LGTM, send a follow-on to remove the one test case or improve it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #194