Open
Conversation
abmusse
commented
Jun 29, 2020
abmusse
force-pushed
the
tests-mute-dep-warnings
branch
from
fc4f2d1 to
074678d
Compare
|
👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed. |
kadler
reviewed
Oct 21, 2020
Comment on lines
+53
to
+55
| const temp = deprecation; | ||
| deprecation = null; | ||
| return temp; |
Member
There was a problem hiding this comment.
Do we have to worry about race conditions here? Can mocha run tests simultaneously?
Member
Author
There was a problem hiding this comment.
By default mocha runs test serially. So in step 12 it describes the flow of execution:
So I don't think there would be issue of tests running simultaneously unless we were using parallel mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mute deprecation warnings by capturing the deprecation event emitted by the process with:
process.on('deprecation', fn)
Within the test cases we ensure that the deprecated functions emit a deprecation warning.
Resolves #150