Skip to content

refactor: Handle optional dependencies better#306

Merged
kadler merged 2 commits intomasterfrom
handle-optional-deps
Dec 8, 2020
Merged

refactor: Handle optional dependencies better#306
kadler merged 2 commits intomasterfrom
handle-optional-deps

Conversation

@abmusse
Copy link
Member

@abmusse abmusse commented Jul 23, 2020

Resolves #290

@abmusse abmusse requested a review from kadler July 23, 2020 23:17
@github-actions
Copy link

👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Aug 24, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label Aug 24, 2020
@github-actions github-actions bot closed this Oct 6, 2020
@kadler kadler removed the stale label Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment

@kadler kadler merged commit c02b799 into master Dec 8, 2020
@kadler kadler deleted the handle-optional-deps branch December 8, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep-open Exempts stale action from auto closing the issue/pr.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle optional dependencies better

2 participants