Skip to content

docs: Add omit as valid value for io#346

Merged
abmusse merged 1 commit intoIBM:masterfrom
alanseiden:patch-1
Oct 25, 2022
Merged

docs: Add omit as valid value for io#346
abmusse merged 1 commit intoIBM:masterfrom
alanseiden:patch-1

Conversation

@alanseiden
Copy link
Contributor

@alanseiden alanseiden commented Oct 14, 2022

Resolves #343

@alanseiden alanseiden mentioned this pull request Oct 14, 2022
@alanseiden
Copy link
Contributor Author

@abmusse What do you think? This PR would resolve #343

@abmusse abmusse self-requested a review October 20, 2022 15:21
Copy link
Member

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Before merging can you please sign off the commit for DCO to pass.

Also can you fixup the commit message with the docs: prefix?

docs: Add omit as valid value for io

We use conventional commits for our commits.

@alanseiden alanseiden changed the title Add omit as valid value for io Add omit as valid value for io Signed-off-by: Author Name <authoremail@example.com> Oct 20, 2022
@alanseiden alanseiden changed the title Add omit as valid value for io Signed-off-by: Author Name <authoremail@example.com> Add omit as valid value for io Oct 20, 2022
@alanseiden alanseiden changed the title Add omit as valid value for io docs: Add omit as valid value for io Oct 20, 2022
Signed-off-by: Alan Seiden <alan@alanseiden.com>
Copy link
Member

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abmusse abmusse merged commit 6567f2e into IBM:master Oct 25, 2022
This was referenced Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

*OMIT not supported

2 participants