build(deps): Updated deps to the latest version#347
Merged
Conversation
- Drop standard-version as it is now deprecated - Update mocha binaray name in test scripts
Member
Author
|
Bumping to newer version of |
Member
Author
|
For the changes in 0eb4b89 I ran: ./node_modules/eslint/bin/eslint.js lib/ test/ --fixThen manually disabled the following rules in the appropriate files
|
Member
Author
|
Ran integration tests manually: |
markirish
approved these changes
Oct 25, 2022
Contributor
markirish
left a comment
There was a problem hiding this comment.
LGTM
Just had a LUG customer asking about npm audit warnings, so it is a very timely PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After these changes running npm audit returns:
Still need to investigate possible breaking changes in ssh2 1.x.x in #338