Skip to content

fix: Better optional deps handling #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abmusse merged 3 commits into from
Oct 27, 2022
Merged

fix: Better optional deps handling #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53f9bf1
fix: Better optional deps handling
abmusse Oct 26, 2022
9d13b7b
fixup! fix: Better optional deps handling
abmusse Oct 26, 2022
12083c9
fixup! fixup! fix: Better optional deps handling
abmusse Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/transports/idbTransport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ try {
}

function idbCall(config, xmlInput, cb) {
// idb transport is not available bail out
if (idb === null) {
cb(new Error('idb-connector was not found, ensure idb-connector is installed properly (idb-connector is only available on IBM i).'), null);
}

const {
database = '*LOCAL',
username = null,
Expand Down
5 changes: 5 additions & 0 deletions lib/transports/odbcTransport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ try {
}

function odbcCall(config, xmlInput, done) {
// odbc transport is not available bail out
if (odbc === null) {
done(new Error('odbc transport was not found, ensure odbc is installed properly.'), null);
}

const {
host = 'localhost',
username = null,
Expand Down