Address vulnerabilities in docs packages#382
Merged
Conversation
Member
I think that would make the most sense. Could we just pin the specific version of sphinx-js? From there docs looks like it pulls in the version of Sphinx it needs See Step 2: https://github.com/mozilla/sphinx-js#setup |
Member
Author
|
I think for now let's just address these vulnerabilities. Later we can decide how we want to handle the docs deps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certifi version shouldn't matter. In fact most of these shouldn't matter. Perhaps we should just pin the Sphinx package versions?