feat: add pgxpool_empty_acquire_wait_time_seconds#16
Conversation
miparnisari
force-pushed
the
pgxpool_empty_acquire_wait_time
branch
from
afbc5b8 to
954758e
Compare
miparnisari
changed the title
miparnisari
force-pushed
the
pgxpool_empty_acquire_wait_time
branch
2 times, most recently
from
e97b48d to
a812ce5
Compare
|
@iainduncani @molepigeon can you review? Thanks! |
iainduncani
left a comment
iainduncani
left a comment
There was a problem hiding this comment.
Thanks for the reminder @miparnisari, sorry for taking so long to get back to you!
I wondered if this was quite similar to the existing pgxpool_acquire_duration_ns and if it would be better to have both of them as the same unit and given the existing one is in nanoseconds if this new one should also be.
Is there something inherently different about the two that I am missing that means they should be different units?
|
@iainduncani moved to
i don't remember why i did with |
Signed-off-by: Maria Ines Parnisari <maria.ines.parnisari@authzed.com>
Signed-off-by: Maria Ines Parnisari <maria.ines.parnisari@authzed.com>
miparnisari
force-pushed
the
pgxpool_empty_acquire_wait_time
branch
from
39dd0d4 to
2066030
Compare
|
@miparnisari just back from vacation - thanks for updating the PR and contributing :-) |
2 participants
No description provided.