fix: Quote CL cmd in iCmd5250 for shell escaping

[kadler]

iCmd5250 is just a fancy wrapper around iSh, using the PASE system
command. It did not do any shell escaping/quoting, so it basically only
allowed calling CL commands without parameters or with only positional
parameters because the parentheses would cause the shell to gack.

eg.
iCmd5250('wrkactjob', 'WRKACTJOB SBS(QBATCH)')

basically became

iSh('wrkactjob', '/QOpenSys/usr/bin/system WRKACTJOB SBS(QBATCH)')

When executed, an error would be given from the shell:

sh: syntax error at line 1 : `(' unexpected

The proper fix is to quote the string, but that can be tricky to get
right. Luckily, Python has shlex.quote to do the hard work for us.
https://docs.python.org/3/library/shlex.html#shlex.quote

Fixes #49

[kadler]

@ranga543 Can you please test this? I was able to verify with this script:

from itoolkit import *
from itoolkit.transport import DirectTransport

itransport = DirectTransport()
itool = iToolKit()
itool.add(iCmd('aspgroup_cmd', 'SETASPGRP ASPGRP(TEST)'))
itool.add(iCmd5250('dspjob', 'DSPJOB'))

itool.call(itransport)

print(itool.dict_out('aspgroup_cmd'))

for line in itool.dict_out('dspjob')['dspjob'].split('\n'):
    if 'ASP' not in line:
        continue

    print(line)

Note that you must use iCmd to run the SETASPGRP, since iCmd5250 executes in a separate process, so it changes that job, not the current job.

[ranga543]

@kadler I copied your code and tried it and that seems to be working.

[ranga543]

@kadler Is there a way to capture error from iCmd5250 right now it's just throwing CPF ?

CPF9801: Object X in library X not found.
{u'aspgroup_cmd': {u'success': u'+++ success SETASPGRP ASPGRP(TEST)'}, u'dspjob': {}}

[ranga543]

@kadler any ideas ?

[kadler]

I'm not sure exactly what you're asking for, but in general error handling in XMLSERVICE is an after thought and there's not much that itoolkit can do about it.