Open
Conversation
Fixed License Headers # Copyright contributors to the python-itoolkit project # SPDX-License-Identifier: MIT Signed-off-by: jennifer566 <jennifer4evermore@yahoo.com>
jennifer566
force-pushed
the
fix-license-headers
branch
from
52d4122 to
83c917d
Compare
kadler
reviewed
Oct 23, 2023
Member
kadler
left a comment
kadler
left a comment
There was a problem hiding this comment.
I do see that doing this puts the coding line on line 3 for files which have it. This breaks PEP 263, which says that it must be on line 1 or 2 to be used, but the PEP 8 style guide says it shouldn't be used anyway: https://peps.python.org/pep-0008/#source-file-encoding so I guess that's fine.
Can you please update the python files in the tests/ and samples/ directories too?
Member
|
Looks like I need to update the github action to handle the coverage report from external contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed License Headers https://github.com/IBM/python-itoolkit/issues/83