Skip to content

Conversation

@gary1998
Copy link
Contributor

@gary1998 gary1998 commented Apr 28, 2022

PR summary

Security Insights is being deprecated out of SCC, so removing corresponding services, i.e. FindingsAPI.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

BREAKING CHANGE: deprecating Security Insights
Copy link
Collaborator

@Laxmoji Laxmoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@Laxmoji Laxmoji merged commit 7458078 into main Aug 5, 2022
sccdeveloper added a commit that referenced this pull request Aug 5, 2022
# [3.0.0](2.0.1...3.0.0) (2022-08-05)

### Bug Fixes

* **FindingsAPI:** deprecated ([fe11482](fe11482))

* Merge pull request #51 from IBM/si-deprecation ([7458078](7458078)), closes [#51](#51)

### BREAKING CHANGES

* Deprecating Security Insights
* **FindingsAPI:** deprecating Security Insights
@sccdeveloper
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gary1998 gary1998 deleted the si-deprecation branch August 28, 2023 13:08
pavanm87 pushed a commit that referenced this pull request Sep 12, 2023
# [3.0.0](2.0.1...3.0.0) (2022-08-05)

### Bug Fixes

* **FindingsAPI:** deprecated ([fe11482](fe11482))

* Merge pull request #51 from IBM/si-deprecation ([7458078](7458078)), closes [#51](#51)

### BREAKING CHANGES

* Deprecating Security Insights
* **FindingsAPI:** deprecating Security Insights
pavanm87 pushed a commit that referenced this pull request Sep 12, 2023
# [3.0.0](2.0.1...3.0.0) (2022-08-05)

### Bug Fixes

* **FindingsAPI:** deprecated ([fe11482](fe11482))

* Merge pull request #51 from IBM/si-deprecation ([7458078](7458078)), closes [#51](#51)

### BREAKING CHANGES

* Deprecating Security Insights
* **FindingsAPI:** deprecating Security Insights

Signed-off-by: Pavan K Manda <pavankumar.manda87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants