Bump fms-extras version to avoid torch 2.3.0 issue#82
Merged
Conversation
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
tdoublep
force-pushed
the
tpa-fms-extras-bump
branch
from
a7c68ce to
5d5b2d3
Compare
joerunde
approved these changes
May 3, 2024
JRosenkranz
pushed a commit
that referenced
this pull request
May 6, 2024
#### Motivation Torch 2.3.0 was released last week and fms-extras was pulling it in as a build dependency, leading to symbol conflicts with torch 2.2.1 (what we are using currently). I've changed the versioning inside fms-extras to ensure this doesn't happen. #### Modifications Just bumping version for fms-extras #### Result Resolves ImportErrors that are present with current main: ``` ImportError: /opt/tgis/lib/python3.11/site-packages/fms_extras/paged_c.cpython-311-x86_64-linux-gnu.so: undefined symbol: _ZN3c104cuda14ExchangeDeviceEa ``` #### Related Issues n/a Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: Joshua Rosenkranz <jmrosenk@us.ibm.com>
Xaenalt
pushed a commit
to Xaenalt/text-generation-inference
that referenced
this pull request
Jul 30, 2024
Torch 2.3.0 was released last week and fms-extras was pulling it in as a build dependency, leading to symbol conflicts with torch 2.2.1 (what we are using currently). I've changed the versioning inside fms-extras to ensure this doesn't happen. Just bumping version for fms-extras Resolves ImportErrors that are present with current main: ``` ImportError: /opt/tgis/lib/python3.11/site-packages/fms_extras/paged_c.cpython-311-x86_64-linux-gnu.so: undefined symbol: _ZN3c104cuda14ExchangeDeviceEa ``` n/a Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Xaenalt
pushed a commit
to Xaenalt/text-generation-inference
that referenced
this pull request
Sep 16, 2024
sync release with main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Torch 2.3.0 was released last week and fms-extras was pulling it in as a build dependency, leading to symbol conflicts with torch 2.2.1 (what we are using currently). I've changed the versioning inside fms-extras to ensure this doesn't happen.
Modifications
Just bumping version for fms-extras
Result
Resolves ImportErrors that are present with current main:
Related Issues
n/a