Modify -DCMAKE_INSTALL_RPATH for MacOS#30
Merged
yury-lysogorskiy merged 1 commit intoICAMS:masterfrom Jun 13, 2023
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you so much developers for sharing the code, which helps me quite a lot for jumping into ML-potential researches!
Short description
This modification allows us to use
pacemakeralso in MacOS.Long description
When I installed
pyacein MacOS and tried to usepacemaker, I got the following error message;In a Linux system, I did not get the error above.
After a bit of surveys and trials, I realized that giving
@loader_pathinstead of$ORIGINtoCMAKE_INSTALL_RPATHinsetup.py(or maybe equivalently inCMakeLists.txt) for MacOS solves the issue.I am honestly not very familiar with cmake and pybind11 and cannot tell clearly why the above worked, but this may be not super unreasonable (https://stackoverflow.com/q/53428219).