First attempt at adding 2D psd plotting function#23
Open
KathrynJones1 wants to merge 10 commits intoICSM:mainfrom
Open
First attempt at adding 2D psd plotting function#23KathrynJones1 wants to merge 10 commits intoICSM:mainfrom
KathrynJones1 wants to merge 10 commits intoICSM:mainfrom
Conversation
pscicluna
requested changes
Oct 21, 2022
| self.likelihood, | ||
| num_mixtures=num_mixtures) #Add missing arguments | ||
| num_mixtures=num_mixtures) # Add missing arguments |
Collaborator
There was a problem hiding this comment.
Suggested change
| num_mixtures=num_mixtures) # Add missing arguments | |
| num_mixtures=num_mixtures) #Add missing arguments |
|
|
||
| # Initialize plot | ||
| fig, ax = plt.subplots(1, 1, figsize=(8, 6)) | ||
| # Initialise plot |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Initialise plot | |
| # Initialise plot |
| # Initialize plot | ||
| fig, ax = plt.subplots(1, 1, figsize=(8, 6)) | ||
| # Initialise plot | ||
| fig, ax = plt.subplots(1, 1, figsize=(8, 6)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| fig, ax = plt.subplots(1, 1, figsize=(8, 6)) | |
| fig, ax = plt.subplots(1, 1, figsize=(8, 6)) |
| else: | ||
| return fig, ax | ||
|
|
||
| if means.ndim == 2: # 2D case |
Collaborator
There was a problem hiding this comment.
I'm not sure if the indentation here is correct - it looks like it might have once level of indentation too few, but I'm getting confused by all my previous comments...
Co-authored-by: Peter Scicluna <pscicluna@users.noreply.github.com>
Co-authored-by: Peter Scicluna <pscicluna@users.noreply.github.com>
Co-authored-by: Peter Scicluna <pscicluna@users.noreply.github.com>
Co-authored-by: Peter Scicluna <pscicluna@users.noreply.github.com>
Co-authored-by: Peter Scicluna <pscicluna@users.noreply.github.com>
Co-authored-by: Peter Scicluna <pscicluna@users.noreply.github.com>
Co-authored-by: Peter Scicluna <pscicluna@users.noreply.github.com>
Collaborator
|
@KathrynJones1 are you up for resuming work on pgmuvi and getting this finished? It's okay if not, I can push the last few changes through and clean it up later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guessed at a lot of the shapes, since we're not sure what they will be yet. It's also hard to check everything is compatible before running it.
Also need to investigate which psd you need to subtract to avoid interference (we're not sure about 2D yet).