Minor changes#120
Merged
Merged
Conversation
ffelten
requested changes
May 2, 2025
Collaborator
ffelten
left a comment
ffelten
left a comment
There was a problem hiding this comment.
Thanks !
I think you can update the random_design method in core. Makes sense to me.
Contributor
Author
I'll leave this one till later for now - since mypy will complain if we don't get the overloads right. |
ffelten
reviewed
May 2, 2025
ffelten
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also modified the function
random_designin each problem to have additional attributesdataset_key: str = "train", design_key: str = "initial_design", since it was bothering me that it was hardcoded. I would have modified it incore, since a good amount of the problems have the same basicrandom_designfunction, but I think this would go against the generic aspect of that code.Added an
optistepsrender function, removed closed curve constraint + slightly cleaned documentation and some other minor things.