Better pyright config#145
Merged
Merged
Conversation
g-braeunlich
approved these changes
Jul 1, 2025
Collaborator
g-braeunlich
left a comment
g-braeunlich
left a comment
There was a problem hiding this comment.
LGTM.
Also think that we dont need pyright anymore. I am not aware of any important lint/check which is not covered by mypy/ruff.
But maybe we should consider ty at some time.
Collaborator
Author
Agreed. I'd wait for ty to be more stable (it is still in alpha). But once it becomes mature, I don't see any reason against it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Un-ignore some rules. I also fixed a bunch of places where pyright was now complaining.
PS: I'm not even sure we want to keep pyright and mypy in the long run. Mypy seems to work better/is less annoying.