Support apptainer instead of singularity#152
Conversation
|
@ffelten In Instead of the changes of the commit class Apptainer(Singularity):
"""Apptainer."""
name = "apptainer"
executable = "apptainer"So we support both |
|
@ffelten May I cherry-pick 6a8339e to this branch, replacing Use apptainer instead of singularity? |
|
@g-braeunlich sure! Good idea |
|
Note: my student just confirmed that this new version does not have clashes relating to MPI (from different jobs) writing in the same tmp folder. |
|
@ffelten I cherry-picked and rewrote the history a bit (squashed your commits, changed the commit message) into a new branch: support_apptainer-rebased. git diff origin/feat/support_apptainer origin/feat/support_apptainer-rebased |
|
After my changes, my only suggestion would be to use tempfile.TemporaryDirectory instead of |
|
I guess we should close this one? |
|
The new branch was actually meant as a proposal to replace this branch, e.g. locally, on git fetch
git reset --hard origin/feat/support_apptainer-rebased
git push -f |
98d091d to
9df3fee
Compare
|
@g-braeunlich done! Actually, I'm not sure we want to keep supporting singularity; Euler and Zaratan support Apptainer. Moreover, the last commit on the repo was 3 years ago. |
9df3fee to
a7af697
Compare
|
OK. I reverted to apptainer only |
And did you see this? |
Missed it. We can use it indeed. I see you're on the branch. Do you want me to do it or you do it? |
|
OK. I ll change that |
a7af697 to
5f72e29
Compare
|
Changed. I not went for |
5f72e29 to
d8dae9d
Compare
|
Rebased on main (after the multi os PR) |
singularity->apptainerSupport Apptainer #148tmp/mount logic according to what @fgvangessel-umd said and the above point. Frank's feedback on using Slurm #151I'm not sure how to test this though?