Skip to content

core: Fix bug in Problem.check_constraints #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
g-braeunlich merged 1 commit into from
Sep 4, 2025
Merged

core: Fix bug in Problem.check_constraints #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engibench/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def check_constraints(self, design: DesignType, config: dict[str, Any]) -> const
the fields of `config` will be used as default values.
"""
defaults = dataclasses.asdict(self.config) if self.config is not None else {}
checked_config = self.Config(**defaults, **config)
checked_config = self.Config(**{**defaults, **config})
violations = constraint.check_field_constraints(checked_config)

@constraint.constraint
Expand Down
9 changes: 9 additions & 0 deletions tests/test_problem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,15 @@ def test_check_constraints_detects_missing_parameters() -> None:
FakeProblem().check_constraints(design, config)


def test_check_constraints_overrides_default_values() -> None:
design = np.zeros((2, 3))
fake_problem = FakeProblem()
fake_problem.config = FakeProblem.Config(x=10)
config = {"y": 1.0}
violations = fake_problem.check_constraints(design, config)
assert causes(violations) == ["Config.y: 1.0 ∉ [-∞, -1.0]"]


def test_check_constraints_handles_constraints_on_design_and_config() -> None:
@constraint(categories=THEORY, criticality=Criticality.Warning)
def volume_fraction_bound(design: NDArray, volfrac: float) -> None:
Expand Down
Loading