Fix some slurm issues#192
Merged
Merged
Conversation
g-braeunlich
force-pushed
the
container
branch
from
1bd2534 to
2ab214f
Compare
ffelten
reviewed
Sep 25, 2025
| design["angle_of_attack"] = design["angle_of_attack"][0] | ||
|
|
||
| # docker pull image if not already pulled | ||
| if container.RUNTIME is not None and self.container_id is not None: |
Collaborator
There was a problem hiding this comment.
This is done elsewhere then?
Collaborator
Author
There was a problem hiding this comment.
This is done when calling run. Something to be discussed.
But as docker / podman automatically pull when using run, I thought that we should do the same in our API.
E.g. one or both of the heatconduction problems did not pull which caused an error with slurm before.
g-braeunlich
force-pushed
the
container
branch
from
47b3b3b to
345b00f
Compare
ffelten
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is mainly about 2 obvious errors occurring on Euler when running the problems, but also improves support for podman.
Partially fixes #191
Type of change
Please delete options that are not relevant.