Airfoil#202
Merged
Merged
Conversation
Even though optimize is not implemented
g-braeunlich
force-pushed
the
airfoil
branch
4 times, most recently
from
f00bc58 to
c2f890c
Compare
This prevents file collisions when running multiple simultations with the same seed in parallel.
ffelten
approved these changes
Nov 14, 2025
Collaborator
ffelten
left a comment
ffelten
left a comment
There was a problem hiding this comment.
Huge work cleaning this up 🫡🚀
| "make_input_design_blunt": True, | ||
| "input_blunted": False, | ||
| "s0": s0, | ||
| **dataclasses.asdict(self.Conditions()), |
Collaborator
There was a problem hiding this comment.
This is not reflected in the new code I think?
Collaborator
Author
There was a problem hiding this comment.
I think this is actually not needed:
All the content of base_config was fed into the py template. But many of the variables just where not needed by that template. Everything which is needed is now passed as cli_interface.PreprocessParameters
Collaborator
There was a problem hiding this comment.
That's what I thought too. Just wanted to double check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve error handling in airfoil and fix issues
Closes #191
Type of change
Please delete options that are not relevant.