Skip to content

Add tests for container-based problems (only simulation)#203

Merged
ffelten merged 4 commits into
mainfrom
feat/test_container_based_problems
Oct 20, 2025
Merged

Add tests for container-based problems (only simulation)#203
ffelten merged 4 commits into
mainfrom
feat/test_container_based_problems

Conversation

@ffelten
Copy link
Copy Markdown
Collaborator

@ffelten ffelten commented Oct 17, 2025

Description

Adding some automated tests for container-based problems--only simulation since they're pretty heavy.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have run ruff check . and ruff format
  • I have run mypy .
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [ x I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Collaborator

@g-braeunlich g-braeunlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffelten
Copy link
Copy Markdown
Collaborator Author

ffelten commented Oct 17, 2025

@cashend seems like we specify only one objective in the airfoil metdata (cd). In practice, simulate and optimize return two (cl also I guess). Should we change the metadata or not return cl ?

@ffelten ffelten merged commit 2a20373 into main Oct 20, 2025
14 checks passed
@ffelten ffelten deleted the feat/test_container_based_problems branch October 20, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants