Skip to content

fix: add missing max_iter constraint for HeatConduction2D and HeatConduction3D #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiladHB wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: add missing max_iter constraint for HeatConduction2D and HeatConduction3D #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engibench/problems/heatconduction2d/v0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class Config(Conditions):
int, bounded(lower=1).category(THEORY), bounded(lower=10, upper=1000).warning().category(IMPL)
] = 101
"""Resolution of the design space for the initialization"""
max_iter: int = 100
max_iter: Annotated[int, bounded(lower=1).category(THEORY)] = 100
"""Maximum number of iterations for the solver in `optimize()`."""

config: Config
Expand Down
2 changes: 1 addition & 1 deletion engibench/problems/heatconduction3d/v0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class Config(Conditions):
int, bounded(lower=1).category(THEORY), bounded(lower=10, upper=1000).warning().category(IMPL)
] = 51
"""Resolution of the design space"""
max_iter: int = 100
max_iter: Annotated[int, bounded(lower=1).category(THEORY)] = 100
"""Maximum number of iterations for the solver in `optimize()`."""

config: Config
Expand Down
Loading