Skip to content

Main IDR monitoring upgrade#281

Merged
manics merged 4 commits intoIDR:masterfrom
manics:monitoring-upgrade
Nov 30, 2020
Merged

Main IDR monitoring upgrade#281
manics merged 4 commits intoIDR:masterfrom
manics:monitoring-upgrade

Conversation

@manics
Copy link
Copy Markdown
Contributor

@manics manics commented Sep 30, 2020

Upgrades prometheus and grafana.

Partly related to #264

The main breaking changes are changes to metric names, which is why some of the Grafana dashboards are modified.

@manics manics changed the title Monitoring upgrade Main IDR monitoring upgrade Sep 30, 2020
@manics manics mentioned this pull request Oct 7, 2020
Copy link
Copy Markdown
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As general, my worry when I hear "breaking" is that we won't be able to ask historical questions. Can you explain why these happened?

Otherwise, 👍 for keeping monitoring happy & healthy.

"value": [
"omero",
"database",
"docker"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where has docker gone?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been gone for years, ever since we separated the deployment of the VAE from IDR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But isn't it coming back with micro services? (and idr-ftp?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used for selecting a subset of hostnames, it's not actually anything to do with what's running on the system. We don't have nodes named .*docker.*, the current microservice works run the docker micoservices on the omero* servers since some of them require filesystem access anyway.

"targets": [
{
"expr": "(1 - node_filesystem_free{fstype!~\"(nfs|nfs4|overlay|rootfs|rpc_pipefs|tmpfs)\", instance=\"$hostname\"} / node_filesystem_size{fstype!~\"(nfs|nfs4|overlay|rootfs|rpc_pipefs|tmpfs)\", instance=\"$hostname\"}) * 100",
"expr": "(1 - node_filesystem_free_bytes{fstype!~\"(nfs|nfs4|overlay|rootfs|rpc_pipefs|tmpfs)\", instance=\"$hostname\"} / node_filesystem_size_bytes{fstype!~\"(nfs|nfs4|overlay|rootfs|rpc_pipefs|tmpfs)\", instance=\"$hostname\"}) * 100",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the impact of the change? Does that mean that previous values are no longer chartable?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd have to create two charts, one for each metric.

@manics
Copy link
Copy Markdown
Contributor Author

manics commented Nov 18, 2020

@manics
Copy link
Copy Markdown
Contributor Author

manics commented Nov 30, 2020

Any more comments, or shall we merge this?

@manics manics merged commit b1f4866 into IDR:master Nov 30, 2020
@manics manics deleted the monitoring-upgrade branch November 30, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants