Use openstacksdk rather than shade for resources deletion#319
Merged
sbesson merged 2 commits intoIDR:masterfrom Mar 9, 2021
Merged
Use openstacksdk rather than shade for resources deletion#319sbesson merged 2 commits intoIDR:masterfrom
sbesson merged 2 commits intoIDR:masterfrom
Conversation
joshmoore
reviewed
Mar 9, 2021
Member
joshmoore
left a comment
There was a problem hiding this comment.
General 👍 for moving to the non-deprecated library. From my POV, it would have been fine to leave cloud, but that's more a non-issue.
Member
Author
|
Yes, I hesitated to keep the diff minimal vs updating the internal variable to match the class name of the API. I also don't feel strongly either way. It's easy enough to update and retest this PR |
Member
Don't worry about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue encountered during the deletion of
prod93bresources related to the detected ports. To reproduce the problem, run a dry-run deletion against an existing environment (or a freshly created one):After confirm the environment to be deleted (
prod95), the output of the command should list 4 ports to be deleted in theNetworkssection instead of one.Debugging reveals that the issue comes from
deployment/scripts/os-idr-delete.py
Lines 94 to 96 in e8db873
device_ownerandnetwork_idfilters.While trying to track the issue, I noticed that the final release of
shade, 1.33.0, happened a year ago with the package is discontinued in favor ofopenstacksdk. Switching the library also fixes the network detection issue.With this PR, the same dr=yun command as above only lists a single
network:router_interfaceport associated with the environment subnet.The swap IP script is also updated to use
openstacksdk. The only place still dependent onshadeis theopenstack-idr.pyscript used by Ansible. I would propose to get this captured and investigated as a separate issue.