Skip to content

check warnings exists before calling length, closes #69 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
azaroth42 merged 1 commit into from
Oct 17, 2019
Merged

check warnings exists before calling length, closes #69 #70

azaroth42 merged 1 commit into from
Oct 17, 2019

Conversation

@ConorSheehan1
Copy link
Contributor

@ConorSheehan1 ConorSheehan1 commented Dec 5, 2018 •
edited
Loading

closes #69

@coveralls
Copy link

coveralls commented Dec 8, 2018

Coverage Status

Coverage remained the same at 83.607% when pulling 015d0c7 on ConorSheehan1:cannot_fetch_manifest_ui_response into e620780 on IIIF:master.

@azaroth42 azaroth42 merged commit 6caa53e into IIIF:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

no response in ui when manifest cannot be fetched

3 participants

@ConorSheehan1 @coveralls @azaroth42