Skip to content

adding container_templates#2

Closed
laspsandoval wants to merge 1 commit intodevfrom
container_template
Closed

adding container_templates#2
laspsandoval wants to merge 1 commit intodevfrom
container_template

Conversation

@laspsandoval
Copy link
Contributor

No description provided.

Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One initial question is: Do we want this in the main processing repository, or do we want it in separate repositories that someone could point to more easily?
For example, breaking these out into two distinct repositories (update names as you desire)
imap_matlab_processing_example
imap_python_processing_example

Then, if a team wants to base their L3 code on the example, they could just clone that repository and not worry about the other stuff we are adding to the main processing routines. (This also reduces the size of our installed package)

There is quite a bit of Libera content/wording in here still. Do we want to change all of the names over to IMAP with a big find/replace job? Or would that be more confusing?


# When you start the build stage, this Dockerfile by default uses the Ubuntu-based matlab-deps image.
# To check the available matlab-deps images, see: https://hub.docker.com/r/mathworks/matlab-deps
FROM mathworks/matlab-deps:${MATLAB_RELEASE}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM mathworks/matlab-deps:${MATLAB_RELEASE}
FROM mathworks/matlab:${MATLAB_RELEASE}

I think that Matlab now provides pre-built containers so you don't even need to run the mpm stuff below to build your container anymore... https://hub.docker.com/r/mathworks/matlab

So I'm wondering if you can get rid of all the installation work below and then leave in your ARG and COPY examples below.

Comment on lines +4 to +5
For questions contact: laura.sandoval@lasp.colorado.edu or contact
Laura Sandoval via the libera_l2 Slack channel.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For questions contact: laura.sandoval@lasp.colorado.edu or contact
Laura Sandoval via the libera_l2 Slack channel.
For questions contact: laura.sandoval@lasp.colorado.edu


# Building and running a docker image in AWS

You will be given AWS console logins in the future. Don't worry about this for now.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You will be given AWS console logins in the future. Don't worry about this for now.

I don't think we are giving anyone AWS console access.

Comment on lines +6 to +7
RUN apt-get update
RUN apt-get install -y gcc libpq-dev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN apt-get update
RUN apt-get install -y gcc libpq-dev

I don't think they'll need gcc, or if so they can add it. I'm not sure what libpq is? But, basically I think these should be very minimal to keep them small and let our downstream users make them bigger with extra dependencies if need be.


It is recommended that a virtual environment is created within the project:
1. Make a virtual environment using `python -m venv venv` and activate it
with `source venv/bin/activate`. Python 3.10 is required.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with `source venv/bin/activate`. Python 3.10 is required.
with `source venv/bin/activate`. Python 3.10 is required.

I don't think we are making any restrictions on Python version if they are within a container? If we are, then you should also update the base image to be from python3.10 instead of 3.9.

@greglucas
Copy link
Collaborator

@laspsandoval do you want to close this and delete the branch now that you've created the other repositories? Or is there more work to be done here like adding references over to those?

@laspsandoval laspsandoval deleted the container_template branch June 26, 2023 14:41
@laspsandoval laspsandoval mentioned this pull request Sep 12, 2024
subagonsouth added a commit to subagonsouth/imap_processing that referenced this pull request Feb 23, 2026
subagonsouth added a commit that referenced this pull request Feb 24, 2026
…2755)

* Modify create_goodtimes_dataset to take l1b dataset as input
Modify mark_incomplete_spin_sets to take l1b dataset as input using newly added variables/quality flags

* PR feedback #1

* PR feedback #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants