2435 hi l2 updated systematic error calculation#2560
Merged
subagonsouth merged 6 commits intoIMAP-Science-Operations-Center:devfrom Jan 23, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes differences in Hi L2 Uncertainties identified during validation by updating the systematic error calculation and the method for combining calibration products.
Key Changes:
- Updated systematic error calculation to derive from Poisson statistics of background rates
- Modified calibration product combination to use only improved statistical variance (excluding systematic error from weighting)
- Removed negative value clamping in uncertainty calculations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| imap_processing/hi/hi_l2.py | Updated systematic error formula to compute from background Poisson statistics; changed flux weighting to use only improved statistical variance; removed negative value clamping |
| imap_processing/tests/hi/test_hi_l2.py | Updated test expectations to match new flux weighting calculation that excludes systematic error |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
greglucas
approved these changes
Jan 22, 2026
5c619ad
into
IMAP-Science-Operations-Center:dev
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This fixes differences seen in Hi L2 Uncertainties during validation
Updated Files
Closes: #2435