FIX: Add additional packet sequence checking#2603
Merged
lacoak21 merged 2 commits intoIMAP-Science-Operations-Center:devfrom Jan 22, 2026
Merged
FIX: Add additional packet sequence checking#2603lacoak21 merged 2 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21 merged 2 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
We can get a single FIRST / LAST / MIDDLE packet, which isn't the full segment, so we need to add a check for singular packets that are not UNSEGMENTED.
lacoak21
approved these changes
Jan 22, 2026
Contributor
lacoak21
left a comment
There was a problem hiding this comment.
Thanks for figuring this out Greg
58880b4
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can get a single FIRST / LAST / MIDDLE packet, which isn't the full segment, so we need to add a check for singular packets that are not UNSEGMENTED.