MNT: Use pivot_angle from Lo when defining DE direction#2616
Merged
greglucas merged 1 commit intoIMAP-Science-Operations-Center:devfrom Jan 27, 2026
Merged
Conversation
The default IMAP_LO_BASE is 0 degrees, but the nominal pivot angle is 90 degrees, which we need to use when defining look directions in the sky.
greglucas
added
Ins: Lo
greglucas
merged commit 7ce547d
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default IMAP_LO_BASE is 0 degrees, but the nominal pivot angle is 90 degrees, which we need to use when defining look directions in the sky.
Testing locally, I get off_angles right in the middle at index 20 now rather than off the edge at 40 like we did previously. This brings up the question of what does off-angle mean if we have a pivot angle that is not sweeping out a perpendicular stripe. I think it may all work out with how we've defined the transforms, but I don't know for sure. i.e. will the off-angle be 15 +/- 2 instead of 0 +/- 2 if we have a pivot-angle not directly at 90 degrees. I'm just writing this down so I don't forget about this later.
closes #2614