MNT: Add sc velocity to Lo pointing sets in l1c#2625
Merged
greglucas merged 1 commit intoIMAP-Science-Operations-Center:devfrom Jan 28, 2026
Merged
MNT: Add sc velocity to Lo pointing sets in l1c#2625greglucas merged 1 commit intoIMAP-Science-Operations-Center:devfrom
greglucas merged 1 commit intoIMAP-Science-Operations-Center:devfrom
Conversation
Lo doesn't want to wait until CG calculations and wants this information in the l1c pointing set itself when created.
greglucas
added
Ins: Lo
subagonsouth
approved these changes
Jan 28, 2026
greglucas
merged commit 4e4854d
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lo doesn't want to wait until CG calculations and wants this information in the l1c pointing set itself when created.
@subagonsouth I started down the path of removing this from the L2 code as well for Lo, but then ran into issues because of the IBEX test datasets that don't have this variable yet. So I figured it is worthwhile just leaving the sc_velocity addition in the L2 pipeline even if it is already added in L1c pointing sets (I did do a quick check that we can overwrite it without any errors). I figure we can tackle that later if desired to remove the duplication.
closes #2618