FIX: Update the rotation direction for the lo pivot angle#2627
Merged
greglucas merged 1 commit intoIMAP-Science-Operations-Center:devfrom Jan 28, 2026
Merged
Conversation
greglucas
added
Ins: Lo
We need to rotate in the + pivot angle direction. There was an incorrect negative sign to rotate counter clockwise before.
greglucas
force-pushed
the
lo-pivot-angle-fix
branch
from
37c7a3b to
5b3dacc
Compare
Collaborator
Author
|
OK, we just did some quick investigations and think the "-" rotation was actually correct because we want the X/Y values to be positive in the output when pivot platform is around 90 degrees. |
subagonsouth
approved these changes
Jan 28, 2026
Contributor
subagonsouth
left a comment
subagonsouth
left a comment
There was a problem hiding this comment.
Agree with rotating by -pivot_angle. This is because spiceypy.rotate provides the rotation matrix that is "the rotation matrix which describes the rotation of the COORDINATE system through angle radians about the axis whose index is iaxis." Which I have convinced myself means that it is the inverse of the rotation matrix that we want.
greglucas
merged commit c106df1
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to rotate in the + pivot angle direction. There was an incorrect negative sign to rotate counter clockwise before.