updates to swapi ialirt fitting algorithm#2632
Merged
laspsandoval merged 10 commits intoIMAP-Science-Operations-Center:devfrom Jan 30, 2026
Merged
Conversation
Contributor
Author
Contributor
laspsandoval
left a comment
laspsandoval
left a comment
There was a problem hiding this comment.
Looks good. Just a few things to change. Looking forward to seeing the tests.
greglucas
reviewed
Jan 29, 2026
Contributor
Author
|
so far, i've added tests for everything except real packets with only 3 near the peak that havent been truncated to 0 |
1. adds a temporary correction factor based on WIND measurements to be used until the SWAPI L3 science data pipeline is finalized 2. report speed only when the fits fails 3. use `raw count * 16 + 8` instead of `raw count * 16` to avoid truncating to zero counts, which can adversely affect the fits
laspsandoval
force-pushed
the
update-swapi-ialirt-fitting-algorithm
branch
from
c8efc38 to
454865f
Compare
added 2 commits
January 29, 2026 17:07
Contributor
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
hafarooki
commented
Jan 30, 2026
hafarooki
commented
Jan 30, 2026
Contributor
Author
|
The PR is ready to merge now, but we don't currently have any unit tests using real spacecraft packets. For now, I think it's OK to merge without it, but there should really be a unit test with real spacecraft packets, particularly one with zero counts. |
Contributor
Author
|
pre-commit.ci autofix |
laspsandoval
approved these changes
Jan 30, 2026
laspsandoval
merged commit b5d6ea3
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
updates to swapi ialirt fitting algorithm
raw count * 16 + 8instead ofraw count * 16to avoid truncating to zero counts, which can adversely affect the fitsUpdated Files
process_swapi.py: made the aforementioned changesTesting
updated
test_process_swapi.pyto account for the density correction, but did not yet create a test for reporting the speed only when the fits fail, nor for the+8shift in counts from the packet. For the latter, perhaps we could add a test using a real packet wherein there are only 3 nonzero counts near the peak.