2640 bug lo prostar not processing correctly#2642
Merged
greglucas merged 2 commits intoIMAP-Science-Operations-Center:devfrom Jan 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues with IMAP-Lo prostar (star sensor) L1B processing:
- Corrects a misnaming issue where the descriptor was "star" instead of "prostar"
- Fixes a control flow bug where multiple descriptor paths could be executed due to using
ifstatements instead ofelif - Adds a workaround for L1A files having a shcoarse dimension that duplicates epoch
Changes:
- Changed descriptor from "star" to "prostar" to match the L1B logical source name
- Changed descriptor conditional checks from independent
ifstatements toelifchain to ensure mutual exclusivity - Added warning logging for unexpected descriptors
- Added temporary fix for shcoarse DEPEND_0 issue in L1A star sensor files
- Added test coverage for unexpected descriptor warning
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| imap_processing/lo/l1b/lo_l1b.py | Updated descriptor handling: changed "star" to "prostar", converted if statements to elif chain, added warning for unexpected descriptors, and added shcoarse dimension workaround |
| imap_processing/tests/lo/test_lo_l1b.py | Added test to verify warning is logged for unexpected descriptors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
greglucas
approved these changes
Jan 29, 2026
6e68d2c
into
IMAP-Science-Operations-Center:dev
19 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Closes: #2640