IDEX Update event time calculation#2664
Merged
lacoak21 merged 5 commits intoIMAP-Science-Operations-Center:devfrom Feb 10, 2026
Merged
IDEX Update event time calculation#2664lacoak21 merged 5 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21 merged 5 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
tech3371
reviewed
Feb 5, 2026
tech3371
reviewed
Feb 5, 2026
Contributor
tech3371
left a comment
tech3371
left a comment
There was a problem hiding this comment.
I had one minor question to IDEX team but what you had is good.
p.s. yes, I remember that discussion and I thought I was way off based on response I got. I should have push back more :)
greglucas
reviewed
Feb 6, 2026
Collaborator
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
Personally, I think this is slightly confusing with fine first then two coarse counters. Rather than changing the calculate event time, can you just update the one spot of input to combine the two coarse ints into a single int that you pass into the function, rather than reworking the function itself?
greglucas
approved these changes
Feb 10, 2026
lacoak21
merged commit 58e525e
into
IMAP-Science-Operations-Center:dev
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
The IDEX team realized they were using shcoarse for event time calculation. This was actually the time of the packet calculation and not the time when IDEX triggered.
I think @tech3371 you had this concern in the science team meeting a long time ago but I thought they said we were doing it right! Anyway this is the correct way to do it.
Updated Files
-imap_processing/idex/idex_l1a.py