Fix Hi L2 naming of bg variables#2677
Merged
subagonsouth merged 1 commit intoIMAP-Science-Operations-Center:devfrom Feb 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns IMAP-Hi L2 background variable names with the established ENA maps L2 naming convention (per Issue #2676), renaming the background rate fields to their singular + systematic-error forms.
Changes:
- Renamed Hi L2 background variables:
bg_rates→bg_rate,bg_rates_unc→bg_rate_sys_err. - Updated Hi L2 processing code to reference the new background variable names.
- Updated unit tests and HiPointingSet expectations to match the renamed variables.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| imap_processing/hi/hi_l2.py | Updates projected/processed variable sets and computations to use bg_rate / bg_rate_sys_err. |
| imap_processing/ena_maps/ena_maps.py | Updates Hi L1C→L2 variable rename mapping to output bg_rate / bg_rate_sys_err. |
| imap_processing/tests/hi/test_hi_l2.py | Renames test datasets/assertions to use the new background variable names. |
| imap_processing/tests/ena_maps/test_ena_maps.py | Updates HiPointingSet test expectations to the new variable names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
greglucas
approved these changes
Feb 10, 2026
Collaborator
greglucas
left a comment
There was a problem hiding this comment.
Looks good. I checked the yaml CDF attributes and those are already good with the bg_rate definition, so 👍
d969a1d
into
IMAP-Science-Operations-Center:dev
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This just renames the Hi L2 variables:
Closes: #2676