Skip to content

Fix Hi L2 naming of bg variables#2677

Merged
subagonsouth merged 1 commit intoIMAP-Science-Operations-Center:devfrom
subagonsouth:2676-hi-l2---fix-bg_rate-variable-names
Feb 10, 2026
Merged

Fix Hi L2 naming of bg variables#2677
subagonsouth merged 1 commit intoIMAP-Science-Operations-Center:devfrom
subagonsouth:2676-hi-l2---fix-bg_rate-variable-names

Conversation

@subagonsouth
Copy link
Contributor

Change Summary

Overview

This just renames the Hi L2 variables:

  • bg_rates -> bg_rate
  • bg_rates_unc -> bg_rate_sys_err

Closes: #2676

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns IMAP-Hi L2 background variable names with the established ENA maps L2 naming convention (per Issue #2676), renaming the background rate fields to their singular + systematic-error forms.

Changes:

  • Renamed Hi L2 background variables: bg_ratesbg_rate, bg_rates_uncbg_rate_sys_err.
  • Updated Hi L2 processing code to reference the new background variable names.
  • Updated unit tests and HiPointingSet expectations to match the renamed variables.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
imap_processing/hi/hi_l2.py Updates projected/processed variable sets and computations to use bg_rate / bg_rate_sys_err.
imap_processing/ena_maps/ena_maps.py Updates Hi L1C→L2 variable rename mapping to output bg_rate / bg_rate_sys_err.
imap_processing/tests/hi/test_hi_l2.py Renames test datasets/assertions to use the new background variable names.
imap_processing/tests/ena_maps/test_ena_maps.py Updates HiPointingSet test expectations to the new variable names.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I checked the yaml CDF attributes and those are already good with the bg_rate definition, so 👍

@subagonsouth subagonsouth merged commit d969a1d into IMAP-Science-Operations-Center:dev Feb 10, 2026
20 checks passed
@github-project-automation github-project-automation bot moved this to Done in IMAP Feb 10, 2026
@subagonsouth subagonsouth deleted the 2676-hi-l2---fix-bg_rate-variable-names branch February 10, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Hi L2 - fix bg_rate variable names

3 participants