ULTRA l1a image processing error handling#2678
Merged
lacoak21 merged 1 commit intoIMAP-Science-Operations-Center:devfrom Feb 9, 2026
Merged
Conversation
greglucas
approved these changes
Feb 9, 2026
Collaborator
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
Oh, I see now, you were mocking and raising from the mock so you were guaranteed to get the failure. This makes sense to me if it all actually works :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
I had error handling logic in to deal with this issue #2557. Greg fixed it in #2581. This PR just removes the TODO, temporary fix, and test.
Updated Files
Testing
Remove the test that checked the temporary fix.