BUG - Lo L1a DE dimension mismatch#2705
Merged
ahotasu merged 3 commits intoIMAP-Science-Operations-Center:devfrom Feb 20, 2026
Merged
BUG - Lo L1a DE dimension mismatch#2705ahotasu merged 3 commits intoIMAP-Science-Operations-Center:devfrom
ahotasu merged 3 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
sdhoyt
approved these changes
Feb 16, 2026
Contributor
sdhoyt
left a comment
sdhoyt
left a comment
There was a problem hiding this comment.
Looks good. Just need to update the unit test input structures to have the met variable
Tests for Lo L1b now pass.
tech3371
approved these changes
Feb 17, 2026
Contributor
tech3371
left a comment
tech3371
left a comment
There was a problem hiding this comment.
looks good beside one minor comment
test datasets. Re-ran pytest to confirm that the tests still pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2650
Change Summary
Change L1b DE references to use L1a DE "met" field instead of "shcoarse". The former is the same dimension as the "epoch" field, whereas the latter can be longer when segmented packets are present.
File changes
Testing
Manual testing consisting of generation of DE products from 20251215 and 20260212, days which had previously failed and passed, respectfully, prior to this change.