CoDICE l2 fix species GF modes #2707
Merged
lacoak21 merged 1 commit intoIMAP-Science-Operations-Center:devfrom Feb 17, 2026
Merged
CoDICE l2 fix species GF modes #2707lacoak21 merged 1 commit intoIMAP-Science-Operations-Center:devfrom
lacoak21 merged 1 commit intoIMAP-Science-Operations-Center:devfrom
Conversation
tech3371
approved these changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes an unnecessary check from the geometric factor computation logic in CoDICE L2 processing. The change ensures consistency between the angular and non-angular product processing paths.
Changes:
- Removed the redundant
& (rgfo_half_spin > 0)check from the modes calculation for non-angular products - Simplified the logic to match the angular product code path which doesn't have this check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lacoak21
merged commit 59c3dd3
into
IMAP-Science-Operations-Center:dev
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Used reduced modes where half_spin_per_esa_step > rgfo_half_spin and valid_half_spin only
File changes
Remove the logic that checks if rgfo_half_spin is > 0. We no longer need that check.