Lo L1c GoodTime Filter Fix#2758
Open
ahotasu wants to merge 9 commits intoIMAP-Science-Operations-Center:devfrom
Open
Lo L1c GoodTime Filter Fix#2758ahotasu wants to merge 9 commits intoIMAP-Science-Operations-Center:devfrom
ahotasu wants to merge 9 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
like the GoodTime fraction logic at line 684. Reprocessed all L1c PSETs since Jan 17 locally and validated that the new logic is working. Re-ran pytests; all pass.
sdhoyt
approved these changes
Feb 24, 2026
Contributor
subagonsouth
left a comment
subagonsouth
left a comment
There was a problem hiding this comment.
I have a couple of comments.
Collaborator
Author
|
@subagonsouth : Updated logic per yesterday's mapping meeting to return an empty pset instead of simply not producing a pset product. Added test case and also verified using flight data for 20260209, which has no (currently defined) good times. |
things but was still a problem.
error that, somehow, doesn't work when I do a local pre-commit run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the L1c GoodTime filter to be like the GoodTime fraction logic at line 684 as a response to bug #2757.
Change Summary
Changed logic to ensure that the GoodTime is within the pointing time.
Also added logic to return an empty dataset if there are no GoodTimes within the pointing. This seems reasonable to me--it prevents later issues with background rate determination, but I appreciate other thoughts on this solution.
Testing
Reprocessed all L1c PSETs since Jan 17 locally and validated that the new logic is working by inspecting CDFs with MATLAB to ensure that the background rates are all non-zero, which must be the case when the GoodTime filtering is working properly.
Re-ran pytest for Lo L1c; all tests pass.